Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Spring Boot and Class Loading fixes #282

Closed
wants to merge 17 commits into from
Closed

Conversation

Tires
Copy link
Contributor

@Tires Tires commented Mar 29, 2019

Please review thoroughly before integrate.

Best
Dieter

@lincolnthree
Copy link
Member

Hi @Tires Thanks for the PR! Has this really been open since 2019? If so, my apologies. Could you give me a little background about this issue?

Additionally, could you possibly squash the commits down to a single commit to make merging a bit cleaner? It looks like there are a bunch of intermediate / unnecessary changes in the PR commits.

Thank you!

@Tires
Copy link
Contributor Author

Tires commented Oct 29, 2021

The whole years we maintained our old projects with new versions of Java, Spring Boot, Maven etc. If you still want to merge, I think you have to analyze this. We don't use this project anymore, since we deprecated JSF and completely migrated to Spring Boot, Reactor and Netty. Thanks for understanding.

@lincolnthree
Copy link
Member

lincolnthree commented Nov 1, 2023

Closing as out of date. If this is still an issue, please re-open. Thank you for the effort of the PR, and sorry it took so long to review originally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants